[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

[Michał Górny via Phabricator via lldb-commits]

mgorny updated this revision to Diff 442519.
mgorny marked 2 inline comments as done.
mgorny added a comment.

Partial update. Implemented most of the requests, except what noted below. Also implemented support for `%Stdio:` stdout forwarding style as was eventually implemented in LLGS.

I haven't been able to figure out how to make the test suite work without the public-private state change.

As for the `OK` response to `vCtrlC`… it's hard because the incoming packet causes the pending read in `GDBRemoteClientBase::SendContinuePacketAndWaitForResponse()` to succeed, so the `OK` is swallowed there. I can't think of any way to do this that wouldn't be super ugly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126614/new/

https://reviews.llvm.org/D126614

Files:
  lldb/packages/Python/lldbsuite/test/gdbclientutils.py
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
  lldb/source/Target/Process.cpp
  lldb/test/API/functionalities/gdb_remote_client/TestNonStop.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D126614.442519.patch
Type: text/x-patch
Size: 29696 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220706/2564a446/attachment-0001.bin>