[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

[Pavel Labath via Phabricator via lldb-commits]

labath marked an inline comment as done.
labath added inline comments.


================
Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:425
     // and all DT_NEEDED entries on *BSD.
     if (m_initial_modules_added) {
       I = m_rendezvous.loaded_begin();
----------------
mgorny wrote:
> labath wrote:
> > @mgorny: I suspect this workaround may no longer be needed.
> Well, unless I've done it wrong, removing it causes a lot of test regressions.
That is unfortunate, but thanks for checking it out. I still suspect there is some way we could tweak the code to make this unnecessary (IIUC, the main problem here was the lack of an "add" notification but this patch essentially makes lldb ignore all add notifications), but it needs more investigation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128264/new/

https://reviews.llvm.org/D128264