[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

[Michał Górny via Phabricator via lldb-commits]

mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.

The patch itself looks good, however the workaround seems still required on FreeBSD.



================
Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:425
     // and all DT_NEEDED entries on *BSD.
     if (m_initial_modules_added) {
       I = m_rendezvous.loaded_begin();
----------------
labath wrote:
> @mgorny: I suspect this workaround may no longer be needed.
Well, unless I've done it wrong, removing it causes a lot of test regressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128264/new/

https://reviews.llvm.org/D128264