[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 24 08:09:50 PDT 2022


wallace added inline comments.


================
Comment at: lldb/include/lldb/Core/PluginManager.h:346
 
-  static TraceCreateInstanceForSessionFile
+  static TraceCreateInstanceForBundle
   GetTraceCreateCallback(llvm::StringRef plugin_name);
----------------
jj10306 wrote:
> nit:  `FromBundle` makes more sense than `ForBundle` imo
makes sense! will do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128484/new/

https://reviews.llvm.org/D128484



More information about the lldb-commits mailing list