[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle
Jakob Johnson via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 24 06:10:52 PDT 2022
jj10306 accepted this revision.
jj10306 added a comment.
This revision is now accepted and ready to land.
lgtm - thanks for doing this renaming 🙂
================
Comment at: lldb/include/lldb/Core/PluginManager.h:346
- static TraceCreateInstanceForSessionFile
+ static TraceCreateInstanceForBundle
GetTraceCreateCallback(llvm::StringRef plugin_name);
----------------
nit: `FromBundle` makes more sense than `ForBundle` imo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128484/new/
https://reviews.llvm.org/D128484
More information about the lldb-commits
mailing list