[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

[Stephen Hines via Phabricator via lldb-commits]

srhines added a comment.

We had some internal Google folks hit this exact issue recently. I don't think that the same "default" CPU should be used for debugging tools like `llvm-objdump`, and that is the crux of the matter here. Perhaps updating the test to specify "generic" as the CPU when passed to `llvm-objdump` for those tests is the right pattern? Then the default for disassembly should be to have all attributes/features enabled unless the developer specifies on the command line that they want a different target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127741/new/

https://reviews.llvm.org/D127741