[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

Michael Daniels via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 16 12:12:29 PDT 2022


mdaniels created this revision.
mdaniels added reviewers: jingham, clayborg, labath.
Herald added a project: All.
mdaniels requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan() function was
doing the symbol lookup using the demangled name. This stopped working
with https://reviews.llvm.org/D118814. To get things working again, just
use the mangled name for the lookup instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127999

Files:
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp


Index: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
===================================================================
--- lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
+++ lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
@@ -488,7 +488,7 @@
   if (sym == nullptr || !sym->IsTrampoline())
     return thread_plan_sp;
 
-  ConstString sym_name = sym->GetName();
+  ConstString sym_name = sym->GetMangled().GetName(Mangled::ePreferMangled);
   if (!sym_name)
     return thread_plan_sp;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127999.437666.patch
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220616/e5c4a477/attachment.bin>


More information about the lldb-commits mailing list