[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added inline comments.


================
Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:445
+  std::array<wchar_t, 3> drive = {L"_:"};
+  for (auto it = drive_strings.cbegin(); *it != L'\0'; it += wcslen(it) + 1) {
+    // Copy the drive letter to the template string
----------------
FWIW, I had to change `auto it = drive_strings.cbegin()` here into `const wchar_t *it = drive_strings.data()` here, before pushing it, because with MSVC, `wcslen(it)` didn't automatically convert the iterator to a pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126657/new/

https://reviews.llvm.org/D126657