[Lldb-commits] [PATCH] D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:186
   attr.exclude_kernel = 1;
-  attr.sample_type = PERF_SAMPLE_TIME;
-  attr.sample_id_all = 1;
----------------
jj10306 wrote:
> won't we need this in order to get timestamps in the context switching events? I agree we don't need it for the time being so maybe in the diff where you add context switch collection you will reintroduce it 🙂
in a later diff I define separate settings for context switches, so this one should be fine


================
Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:316
-    if (Error mmap_err = perf_event->MmapMetadataAndBuffers(buffer_numpages,
-                                                            buffer_numpages)) {
       return std::move(mmap_err);
----------------
jj10306 wrote:
> In the future if we need to collect itrace we will need a small data buffer.
> Do you plan to collect context switch info as part of the same perf event used for intel pt or will you open a separate event?
context switches are done separately
besides, that let's see in the future if itrace is useful


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125850/new/

https://reviews.llvm.org/D125850