[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

Thu Jun 9 11:57:40 PDT 2022

zequanwu marked an inline comment as done.
zequanwu added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180
     if (!Loc)
-      return Callback(Loc.takeError());
-    if (*Loc)
+      consumeError(Loc.takeError());
+    else if (*Loc)
----------------
zequanwu wrote:
> rnk wrote:
> > Did this change cause the presubmit test failure? DebugInfoDWARFTests/DWARFDie::getLocations looks related.
> Yes. If I don't make this change, several existing tests crashed at here due to `Expected<T> must be checked before access or destruction`. I'm not sure how to fix this.
NVM, I missed a checking for expected above. Reverted this part.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125509/new/

https://reviews.llvm.org/D125509