[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

>> 1. This rev apparently assumes x86_64 only but what about Arm/AArch64?
>
> Where do you get that impression? This should all be architecture independent (or done in the same way for all architectures).

Sorry I just brushed over the code and saw x86_64 specifc obj files in tests.

> 

This looks good to me and I also gave this change a test on AArch64/Windows Surface X pro. No regressions. LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127048/new/

https://reviews.llvm.org/D127048