[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

[Reid Kleckner via Phabricator via lldb-commits]

rnk added a comment.

@labath, ping, I see you just got back from vacation and this is a lot of code, but any high level design feedback would be helpful to know if this is the right direction.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180
     if (!Loc)
-      return Callback(Loc.takeError());
-    if (*Loc)
+      consumeError(Loc.takeError());
+    else if (*Loc)
----------------
Did this change cause the presubmit test failure? DebugInfoDWARFTests/DWARFDie::getLocations looks related.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125509/new/

https://reviews.llvm.org/D125509