[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

[Derek Schuff via Phabricator via lldb-commits]

dschuff added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:256
+  WASM_SEC_TAG = 13,       // Tag declarations
+  WASM_SEC_LAST_KNOWN = 14,// Update this when adding new sections
 };
----------------
aheejin wrote:
> - Does this pass clang-format? Because we don't have a space after `,`.
> - 14 is not actually the last section known, because we don't have a section whose section code is 14. How about doing something like
> ```
> WAS_SEC_LAST_KNOWN = WASM_SEC_TAG;
> ```
> ?
ah, no it doesnt pass clang-format.
Also, agreed that LAST_KNOWN should match TAG rather than the one past-the-end. Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127164/new/

https://reviews.llvm.org/D127164