[Lldb-commits] [PATCH] D126259: Add the ability to specify signal actions (pass, stop or notify) for a signal before a process is created

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:1477-1479
+    bool only_target_values;
+    bool do_clear;
+    bool dummy;
----------------
jingham wrote:
> JDevlieghere wrote:
> > Let's initialize these to the same values as `Clear`.
> I generally don't initialize the Option ivars on construction, on the grounds that it will mislead people into thinking the initialized values actually matter, which they don't.  They are never used nor should they be.  You always have to call OptionParsingStarting before reading in values for the Options, and you have to reset all the variables there.
> 
> But if it bugs you, I can add it.
I vaguely remember at least one bug where we were using an uninitialized value, but maybe the problem there was that we didn't call `OptionParsingStarting`. If it's possible to forget to call that, then we should have an assert enforce that, but that's beyond the scope of this patch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126259/new/

https://reviews.llvm.org/D126259