[Lldb-commits] [PATCH] D125995: [lldb] Fix 'ptsname_r' is only available on macOS 10.13.4 or newer

Wed May 25 09:52:50 PDT 2022

qram9 added a comment.

Hi there,

This change has caused the following warning:

llvm-project/lldb/source/Host/common/PseudoTerminal.cpp:106:20: error: unused function 'use_ptsname' [-Werror,-Wunused-function] static std::string use_ptsname(int fd) { ^

1 error generated.

The build compiler is clang++-12 on Ubuntu- 12.10.

Would you kindly look this over to add a fix?

Best,
Ram

PS:
Exact Build command:
/usr/bin/clang++ -DHAVE_ROUND -DLLDB_CONFIGURATION_DEBUG -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/vss/_work/1/b/llvm/Debug/tools/lldb/source/Host -I/mnt/vss/_work/1/llvm-project/lldb/source/Host -I/mnt/vss/_work/1/llvm-project/lldb/include -I/mnt/vss/_work/1/b/llvm/Debug/tools/lldb/include -I/mnt/vss/_work/1/b/llvm/Debug/include -I/mnt/vss/_work/1/llvm-project/llvm/include -I/mnt/vss/_work/1/llvm-project/llvm/../clang/include -I/mnt/vss/_work/1/b/llvm/Debug/tools/lldb/../clang/include -I/mnt/vss/_work/1/llvm-project/lldb/source -I/mnt/vss/_work/1/b/llvm/Debug/tools/lldb/source -isystem /usr/include/libxml2 -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -g  -fno-exceptions -gsplit-dwarf -std=c++14 -MD -MT tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/PseudoTerminal.cpp.o -MF tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/PseudoTerminal.cpp.o.d -o tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/PseudoTerminal.cpp.o -c /mnt/vss/_work/1/llvm-project/lldb/source/Host/common/PseudoTerminal.cpp

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125995/new/

https://reviews.llvm.org/D125995