[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 24 03:01:00 PDT 2022


DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

Much clearer now, thanks. LGTM with the one nit fixed.



================
Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:42
+            regions.GetMemoryRegionAtIndex(region_idx, region)
+            if illegal_address == None or \
+                region.GetRegionEnd() > illegal_address:
----------------
General rule is to use `is None` instead of `== None`, though the result is the same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126109/new/

https://reviews.llvm.org/D126109



More information about the lldb-commits mailing list