[Lldb-commits] [lldb] c30a8c8 - [lldb] Fix should_skip_simulator_test decorator
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Mon May 23 09:33:57 PDT 2022
Author: Jonas Devlieghere
Date: 2022-05-23T09:33:51-07:00
New Revision: c30a8c80837608ccb190aecb84a723ca00dd87df
URL: https://github.com/llvm/llvm-project/commit/c30a8c80837608ccb190aecb84a723ca00dd87df
DIFF: https://github.com/llvm/llvm-project/commit/c30a8c80837608ccb190aecb84a723ca00dd87df.diff
LOG: [lldb] Fix should_skip_simulator_test decorator
Currently simulator tests get skipped when the reported platform is
macosx rather than darwin. Update the decorator to match both.
Added:
Modified:
lldb/packages/Python/lldbsuite/test/decorators.py
Removed:
################################################################################
diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py
index 8f636024abe91..467530fdfd7e7 100644
--- a/lldb/packages/Python/lldbsuite/test/decorators.py
+++ b/lldb/packages/Python/lldbsuite/test/decorators.py
@@ -378,8 +378,8 @@ def apple_simulator_test(platform):
The SDK identifiers for simulators are iphonesimulator, appletvsimulator, watchsimulator
"""
def should_skip_simulator_test():
- if lldbplatformutil.getHostPlatform() != 'darwin':
- return "simulator tests are run only on darwin hosts"
+ if lldbplatformutil.getHostPlatform() not in ['darwin', 'macosx']:
+ return "simulator tests are run only on darwin hosts."
try:
DEVNULL = open(os.devnull, 'w')
output = subprocess.check_output(["xcodebuild", "-showsdks"], stderr=DEVNULL).decode("utf-8")
More information about the lldb-commits
mailing list