[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/test/API/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py:43
+            if region.GetRegionEnd() > illegal_address:
+                illegal_address = region.GetRegionEnd()
 
----------------
DavidSpickett wrote:
> I'm confused as to what the logic is here now.
> 
> You:
> * read from address 0x0 to fill in error
> * walk the memory regions until the highest one, making the end of that the illegal address
> * assume that the error value from reading 0x0 is the same as you'd get from this new illegal address
> ...
> 
> Or am I missing something and the ptr was just left in accidentally.
> 
> (I would suggest you could jump to the last region in the list straight away but I don't think we actually require them to be sorted, plus sometimes you get multiple regions with the same base)
> 
(same base but different end addresses I mean)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126109/new/

https://reviews.llvm.org/D126109