[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 6 05:44:13 PDT 2022


DavidSpickett created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This does 2 things:

- Moves it after the short options. Which makes sense given it's a niche, default off option. (if 2 files for one option seems a bit much, I am going to reuse them for "memory find" later)
- Fixes the use of repeated commands. For example: memory read buf --show-tags <shows tags> memory read <shows tags>

Added tests for the repetition and updated existing help tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125089

Files:
  lldb/include/lldb/Interpreter/OptionGroupMemoryTag.h
  lldb/source/Commands/CommandObjectMemory.cpp
  lldb/source/Commands/Options.td
  lldb/source/Interpreter/CMakeLists.txt
  lldb/source/Interpreter/OptionGroupMemoryTag.cpp
  lldb/test/API/commands/help/TestHelp.py
  lldb/test/API/linux/aarch64/mte_tag_access/TestAArch64LinuxMTEMemoryTagAccess.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125089.427605.patch
Type: text/x-patch
Size: 11116 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220506/5437c98f/attachment-0001.bin>


More information about the lldb-commits mailing list