[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:520
+
+            # on arm64 systems, if jump through a null function pointer,
+            # we end up at address 0 and the crash reporter unwinder 
----------------
kastiglione wrote:
> (minor) I think a word is missing between "if" and "jump".
yep good catch.


================
Comment at: lldb/examples/python/crashlog.py:533
+                      frame_offset = pc - text_lo
+                      thread.frames.append(self.crashlog.Frame(idx, pc, frame_offset))
+
----------------
kastiglione wrote:
> What do you think of adding a `break` here? Not that it would change the outcome, but it might make the intention of the loop slightly better.
ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125042/new/

https://reviews.llvm.org/D125042