[Lldb-commits] [PATCH] D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0

Thu May 5 17:30:14 PDT 2022

mib added a comment.

In D125042#3495488 <https://reviews.llvm.org/D125042#3495488>, @mib wrote:

> In D125042#3495479 <https://reviews.llvm.org/D125042#3495479>, @jasonmolenda wrote:
>
>> In D125042#3495475 <https://reviews.llvm.org/D125042#3495475>, @JDevlieghere wrote:
>>
>>> Does that mean that the interactive crashlogs (`crashlog -i`) do this correctly?
>>
>> I didn't look at that when I wrote the patch; asked @mib and it sounded like he was going to do that separately.
>
> Interactive crashlogs use the same crashlog parser to fetch the register context, so I think they should work out of the box with this patch applied.

I applied @jasonmolenda's patch to test it with interactive crashlog and I can see the added stack frame as expected.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125042/new/

https://reviews.llvm.org/D125042