[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

Wed May 4 08:47:46 PDT 2022

hawkinsw added a comment.

In D124922#3491267 <https://reviews.llvm.org/D124922#3491267>, @labath wrote:

> Heh, well.. there definitely are, though a lot of things that come to mind right now are not really suitable for a first-time contributor. Is there any specific are that you would like to know (or that you know already)?
>
> One of the things that I ran into recently, but hadn't had time to fix is the relocation processing code in `ObjectFileELF::ApplyRelocations`. It's currently fairly messy, and mixes relocations of different architectures (which generally doesn't work as different constants mean different things depending on the architecture. If you could refactor the function such that it has a clear split between architectures, and still allows for code sharing for relocations that mean the same thing on each architecture, then that would be greatly appreciated.
>
> You can try that out by compiling a .o file for some non-x86 architecture and checking whether lldb can read the debug info without asserting.

Thanks!!

If there is interest in pursuing this patch, I will keep it open!

I have committed several typo changes in the past and I am a fairly seasoned developer. In fact, I have another outstanding patch waiting for review.

I will definitely look in to what you suggest. I hope that you will see some submissions forthcoming. Thanks again!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124922/new/

https://reviews.llvm.org/D124922