[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good. Thanks for the patch. Do you need me to commit this for you?

Left two comments inline, but I can also fix that when I'm pushing it.



================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_static-member-anonymous-namespace.s:5
+# CHECK: (lldb) target variable ug
+# CHECK: (U) ug = (m = 0)
+
----------------
Better use some other number here, as it's fairly easy for a value to accidentally come out as zero.


================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_static-member-anonymous-namespace.s:22-25
+#
+# int main() {
+#   return ug.m;
+# }
----------------
We're not going to be running this, so you don't really need the main function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124409/new/

https://reviews.llvm.org/D124409