[Lldb-commits] [PATCH] D124922: [lldb] Inject commands into log output when directed to file

Wed May 4 08:14:22 PDT 2022

hawkinsw added a comment.

In D124922#3491190 <https://reviews.llvm.org/D124922#3491190>, @labath wrote:

> Just my opinion, but I wouldn't like to complicate the logging architecture with file-only log statements and cross-channel dependencies. If you want to cross-reference some other logging channel with the executed commands then I'd say you should enable both channels. We can definitely talk about making the command feature more prominently in the log stream.

Thanks! I am just trying to be helpful!

You are suggesting that the user would always add `commands` to what you `enable` in order to have this feature? Ie,

`log enable -f lldb.out lldb break commands`

The only reason that would be less than ideal for me (personally) is that there is lots of other output that comes along with `commands` that I might not necessarily want.

Again, just trying to be helpful! Again, I am happy to do whatever the group consensus is!!

Just happy to participate!
Will

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124922/new/

https://reviews.llvm.org/D124922