[Lldb-commits] [lldb] d006773 - [lldb] Remove unused PlatformRemoteDarwinDevice::FindFileInAllSDKs

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2022-05-02T17:34:39-07:00
New Revision: d0067738e0cf764a92e1cc5ee0c8b2af8659bada

URL: https://github.com/llvm/llvm-project/commit/d0067738e0cf764a92e1cc5ee0c8b2af8659bada
DIFF: https://github.com/llvm/llvm-project/commit/d0067738e0cf764a92e1cc5ee0c8b2af8659bada.diff

LOG: [lldb] Remove unused PlatformRemoteDarwinDevice::FindFileInAllSDKs

As far as I can tell this function is unused both upstream and
downstream.

Added: 
    

Modified: 
    lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
    lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp b/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
index be03cdbd5666d..83e98ff4e06a2 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
@@ -382,25 +382,6 @@ const char *PlatformRemoteDarwinDevice::GetDeviceSupportDirectoryForOSVersion()
   return nullptr;
 }
 
-uint32_t PlatformRemoteDarwinDevice::FindFileInAllSDKs(const char *platform_file_path,
-                                              FileSpecList &file_list) {
-  Log *log = GetLog(LLDBLog::Host);
-  if (platform_file_path && platform_file_path[0] &&
-      UpdateSDKDirectoryInfosIfNeeded()) {
-    const uint32_t num_sdk_infos = m_sdk_directory_infos.size();
-    lldb_private::FileSpec local_file;
-    // First try for an exact match of major, minor and update
-    for (uint32_t sdk_idx = 0; sdk_idx < num_sdk_infos; ++sdk_idx) {
-      LLDB_LOGV(log, "Searching for {0} in sdk path {1}", platform_file_path,
-                m_sdk_directory_infos[sdk_idx].directory);
-      if (GetFileInSDK(platform_file_path, sdk_idx, local_file)) {
-        file_list.Append(local_file);
-      }
-    }
-  }
-  return file_list.GetSize();
-}
-
 bool PlatformRemoteDarwinDevice::GetFileInSDK(const char *platform_file_path,
                                      uint32_t sdk_idx,
                                      lldb_private::FileSpec &local_file) {

diff  --git a/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h b/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h
index 02cb09df7f77f..6623a94f5745c 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h
@@ -97,15 +97,9 @@ class PlatformRemoteDarwinDevice : public PlatformDarwin {
                                                llvm::sys::fs::file_type ft,
                                                llvm::StringRef path);
 
-  uint32_t FindFileInAllSDKs(const char *platform_file_path,
-                             FileSpecList &file_list);
-
   bool GetFileInSDK(const char *platform_file_path, uint32_t sdk_idx,
                     FileSpec &local_file);
 
-  uint32_t FindFileInAllSDKs(const FileSpec &platform_file,
-                             FileSpecList &file_list);
-
   uint32_t GetConnectedSDKIndex();
 
   // Get index of SDK in SDKDirectoryInfoCollection by its pointer and return