[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

Mon May 2 16:19:43 PDT 2022

clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lldb/include/lldb/Target/Language.h:225
+  // symbol was really B::A::my_function.  We want that to be
+  // a match.  But we wouldn't want this to match AnotherB::A::my_function.  The
+  // user is specifying a truncated path, not a truncated set of characters.
----------------
jingham wrote:
> clayborg wrote:
> > The comment should be adding something extra to "A" right? See suggested code change 
> Yes, the comment was wrong.  I had a fancier example that was taking too many characters and I didn't delete enough when simplifying.  But I'm not sure what code change you are referring to?  I don't see how this is related to GetFunctionName.
It isn't related to GetFunctionName, I have a code change that you can see on the web page that suggests the edit to make to fix the comment. I see you fixed the comment, so nothing more needed for this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124579/new/

https://reviews.llvm.org/D124579