[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

[Zequan Wu via Phabricator via lldb-commits]

zequanwu added inline comments.


================
Comment at: lldb/include/lldb/Symbol/UnwindPlan.h:266
+      int32_t GetRaSearchOffset() const {
+        return m_type == isRaSearch ? m_value.ra_search.search_offset & ~1 : 0;
+      }
----------------
zequanwu wrote:
> clayborg wrote:
> > Are we assuming "search_offset" must be aligned to at least a 4 bit boundary so that we can put something in bit zero?
> search_offset is usually the multiple of 4 or 8, so we can use the last bit.
Updated: 
Use extra bool variable for is_first_search, because search_offset might be an odd number if parameter byte size in stack is an odd number.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124198/new/

https://reviews.llvm.org/D124198