[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

You might want to try fun cases like `operator<` and `operator()()` from a lambda. They should work but might be worth throwing them in.



================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:330
+
+//  size_t from = 0;
+//  llvm::StringRef demangled_ref = demangled.GetStringRef();
----------------
dead code?


================
Comment at: lldb/tools/CMakeLists.txt:11
 
-add_lldb_tool_subdirectory(lldb-instr)
+#add_lldb_tool_subdirectory(lldb-instr)
 add_lldb_tool_subdirectory(lldb-vscode)
----------------
Did you mean to delete this line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124579/new/

https://reviews.llvm.org/D124579