[Lldb-commits] [lldb] d738d47 - Disable symbol on-demand feature for Windows

[Jeffrey Tan via lldb-commits]

Author: Jeffrey Tan
Date: 2022-04-26T13:35:34-07:00
New Revision: d738d4717f6da88494683da62648f91f04f7c8ce

URL: https://github.com/llvm/llvm-project/commit/d738d4717f6da88494683da62648f91f04f7c8ce
DIFF: https://github.com/llvm/llvm-project/commit/d738d4717f6da88494683da62648f91f04f7c8ce.diff

LOG: Disable symbol on-demand feature for Windows

Symbol on-demand feature is never tested on Windows so it is not a surprise
that we are getting Buildbot failure from Windows:
https://lab.llvm.org/buildbot/#/builders/83/builds/18228

This patch disables symbol on-demand feature on Windows. I will find a Windows
machine to test and re-enable symbol on-demand feature as follow-up.

Differential Revision: https://reviews.llvm.org/D124471

Added: 
    

Modified: 
    lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
    lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
    lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
    lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
    lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py b/lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
index 263dccdc5ed70..1a1d3643a6481 100644
--- a/lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
+++ b/lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
@@ -20,6 +20,7 @@ def check_location_file(self, bp, loc, test_name):
         comp_name = comp_unit.GetFileSpec().GetFilename()
         return comp_name == test_name
 
+    @skipIfWindows
     def test_regex_breakpoint_language(self):
         """Test that the name regex breakpoint commands obey the language filter."""
 
@@ -65,6 +66,7 @@ def test_regex_breakpoint_language(self):
             objc_bp.GetNumLocations(), 0,
             "No ObjC symbol matches")
 
+    @skipIfWindows
     def test_by_name_breakpoint_language(self):
         """Test that the name regex breakpoint commands obey the language filter."""
 

diff  --git a/lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py b/lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
index 13490cc8cd19c..4fd3bbf74bf07 100644
--- a/lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
+++ b/lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
@@ -13,6 +13,7 @@
 class TestSourceTextRegexBreakpoint(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
+    @skipIfWindows
     def test_with_run_command(self):
         self.build()
 

diff  --git a/lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py b/lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
index 51a8e3a79fb3b..dd14594159474 100644
--- a/lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
+++ b/lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
@@ -38,6 +38,7 @@ def common_setup(self):
         ctx = self.platformContext
         self.shared_lib_name = ctx.shlib_prefix + "foo." + ctx.shlib_extension
 
+    @skipIfWindows
     def test_source_line_breakpoint(self):
         self.build()
         self.common_setup()
@@ -75,6 +76,7 @@ def test_source_line_breakpoint(self):
         )
         self.assertEqual(7, parent_frame.GetLineEntry().GetLine())
 
+    @skipIfWindows
     def test_symbolic_breakpoint(self):
         self.build()
         self.common_setup()
@@ -112,6 +114,7 @@ def test_symbolic_breakpoint(self):
         )
         self.assertEqual(7, parent_frame.GetLineEntry().GetLine())
 
+    @skipIfWindows
     def test_global_variable_hydration(self):
         self.build()
         self.common_setup()

diff  --git a/lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test b/lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
index 465a6e1f322cf..8c1f086ebc0c7 100644
--- a/lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
+++ b/lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
@@ -1,5 +1,6 @@
 # Test shows that source line breakpoint works with LLDB on demand symbol loading.
 
+# UNSUPPORTED: system-windows
 # RUN: mkdir -p %t
 # RUN: cd %t
 # RUN: %build %p/Inputs/basic.cpp -o basic.out

diff  --git a/lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test b/lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test
index d8f61aad4c45a..69513aab0e239 100644
--- a/lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test
+++ b/lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test
@@ -1,5 +1,6 @@
 # Test shows that symbolic function breakpoint works with LLDB on demand symbol loading.
 
+# UNSUPPORTED: system-windows
 # RUN: mkdir -p %t
 # RUN: cd %t
 # RUN: %build %p/Inputs/basic.cpp -o basic.out