[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

[jeffrey tan via Phabricator via lldb-commits]

yinghuitan created this revision.
yinghuitan added reviewers: clayborg, labath, jingham, JDevlieghere, jdoerfert, DavidSpickett.
Herald added a project: All.
yinghuitan requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Symbol on-demand feature is never tested on Windows so it is not a surprise
that we are getting Buildbot failure from Windows:
https://lab.llvm.org/buildbot/#/builders/83/builds/18228

This patch disables symbol on-demand feature on Windows. I will find a Windows
machine to test and re-enable symbol on-demand feature as follow-up.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124471

Files:
  lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
  lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
  lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
  lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
  lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test


Index: lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test
===================================================================
--- lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test
+++ lldb/test/Shell/SymbolFile/OnDemand/symbolic-breakpoint.test
@@ -1,5 +1,6 @@
 # Test shows that symbolic function breakpoint works with LLDB on demand symbol loading.
 
+# UNSUPPORTED: system-windows
 # RUN: mkdir -p %t
 # RUN: cd %t
 # RUN: %build %p/Inputs/basic.cpp -o basic.out
Index: lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
===================================================================
--- lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
+++ lldb/test/Shell/SymbolFile/OnDemand/source-breakpoint.test
@@ -1,5 +1,6 @@
 # Test shows that source line breakpoint works with LLDB on demand symbol loading.
 
+# UNSUPPORTED: system-windows
 # RUN: mkdir -p %t
 # RUN: cd %t
 # RUN: %build %p/Inputs/basic.cpp -o basic.out
Index: lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
===================================================================
--- lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
+++ lldb/test/API/symbol_ondemand/shared_library/TestSharedLib.py
@@ -38,6 +38,7 @@
         ctx = self.platformContext
         self.shared_lib_name = ctx.shlib_prefix + "foo." + ctx.shlib_extension
 
+    @skipIfWindows
     def test_source_line_breakpoint(self):
         self.build()
         self.common_setup()
@@ -75,6 +76,7 @@
         )
         self.assertEqual(7, parent_frame.GetLineEntry().GetLine())
 
+    @skipIfWindows
     def test_symbolic_breakpoint(self):
         self.build()
         self.common_setup()
@@ -112,6 +114,7 @@
         )
         self.assertEqual(7, parent_frame.GetLineEntry().GetLine())
 
+    @skipIfWindows
     def test_global_variable_hydration(self):
         self.build()
         self.common_setup()
Index: lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
===================================================================
--- lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
+++ lldb/test/API/symbol_ondemand/breakpoint_source_regex/TestSourceTextRegexBreakpoint.py
@@ -13,6 +13,7 @@
 class TestSourceTextRegexBreakpoint(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
+    @skipIfWindows
     def test_with_run_command(self):
         self.build()
 
Index: lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
===================================================================
--- lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
+++ lldb/test/API/symbol_ondemand/breakpoint_language/TestBreakpointLanguageOnDemand.py
@@ -20,6 +20,7 @@
         comp_name = comp_unit.GetFileSpec().GetFilename()
         return comp_name == test_name
 
+    @skipIfWindows
     def test_regex_breakpoint_language(self):
         """Test that the name regex breakpoint commands obey the language filter."""
 
@@ -65,6 +66,7 @@
             objc_bp.GetNumLocations(), 0,
             "No ObjC symbol matches")
 
+    @skipIfWindows
     def test_by_name_breakpoint_language(self):
         """Test that the name regex breakpoint commands obey the language filter."""
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124471.425279.patch
Type: text/x-patch
Size: 3319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220426/a10d522a/attachment.bin>