[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

Muhammad Omair Javaid via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 26 03:29:15 PDT 2022


omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.

LGTM. With a minor nit fix about FixAnyAddress vs FixDataAddress if required.



================
Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:288
+  if (lldb::ABISP abi_sp = GetABI())
+    addr = abi_sp->FixDataAddress(addr);
+
----------------
Is this a candidate for FixAnyAddress ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122411/new/

https://reviews.llvm.org/D122411



More information about the lldb-commits mailing list