[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 25 15:10:20 PDT 2022


jasonmolenda added a comment.
Herald added a project: All.

Hi all, getting back to this one after six months, hah.  Reading through Jim's thoughts on this, I think we're OK to add this refinement.  Tatyana also thought that removing this altogether would be an option, but this has been sitting unfixed for a while and I'd like to land the fix to it.  Jim wishes for a world where HandleCommand requires an SBExecutionContext, or one in which we had an established way of deprecating old SB API.  Given that we can't address that at the moment, I'm going to land this patch finally so we're not carrying the problem around for the foreseeable future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111209/new/

https://reviews.llvm.org/D111209



More information about the lldb-commits mailing list