[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Thanks, for your patience. Overall, I'd say this looks pretty clean now -- much cleaner than I originally thought it could be. I don't have any further comments here.

Does anyone else have any thoughts?



================
Comment at: lldb/source/Core/Module.cpp:474
+         eSymbolContextLineEntry | eSymbolContextVariable))
+      symfile->SetLoadDebugInfoEnabled();
+
----------------
Can this be moved into the if block below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121631/new/

https://reviews.llvm.org/D121631