[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

[Zequan Wu via Phabricator via lldb-commits]

zequanwu planned changes to this revision.
zequanwu added a comment.

Thanks for the feedback. As you pointed out that stack scanning without symbol file info is fragile due to function pointers in stack and we don't know the parameter size pushed into the stack.

Originally, I want lldb to do continue unwinding when it encounters some frames are in modules that don't have symbol info and no rbp value, since we have some crash reports with such problem. But later I found that we actually do have the symbol files for those modules. It seems not necessary anymore...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124198/new/

https://reviews.llvm.org/D124198