[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added reviewers: omjavaid, JDevlieghere.
DavidSpickett added a subscriber: JDevlieghere.
DavidSpickett added a comment.

This comes from https://reviews.llvm.org/D118794 on the subject of whether it's ok to just pick one of fixcode/fixdata and assume it'll work.

Of all the uses of Fix, my own memory region changes are the only ones so far that fit FixAnyAddress. The rest look appropriate. I plan to use it in https://reviews.llvm.org/D118794 instead of FixDataAddress.

@JDevlieghere  You did some work around this area in https://reviews.llvm.org/D100521 so can you tell me if this makes sense to add in general? There were some comments there:

  This looks good. Jonas, what do you think about having FixDataAddress() methods in the ABI's. We're going to be quickly sprinkling FixCodeAddress calls throughout lldb at places where Linux/Darwin ABI need them, and it'd be nice if we have the FixDataAddress method available (even if they're identical right now) so someone doesn't need to audit all the calls in the future and adjust them as appropriate.

FixAnyAddress aims to do the same thing but for when we don't know what we have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124000/new/

https://reviews.llvm.org/D124000