[Lldb-commits] [PATCH] D123375: [lldb][intelpt] Reduce trace memory usage by grouping instructions

Alisamar Husain via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 18 02:55:20 PDT 2022


zrthxn added a comment.

I've tried most of these changes to see the effect it has, but in my opinion this adds quite a lot of code complexity for not enough benefit in terms of memory usage which was our goal. I think this will make the DecodedThread even more of a monolith class with single-use subclasses... are you sure we should continue with this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123375/new/

https://reviews.llvm.org/D123375



More information about the lldb-commits mailing list