[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Core/Module.h:820-825
+  void ReportWarningOptimization(
+      llvm::Optional<lldb::user_id_t> debugger_id = llvm::None);
+
+  void ReportWarningUnsupportedLanguage(
+      lldb::LanguageType language,
+      llvm::Optional<lldb::user_id_t> debugger_id = llvm::None);
----------------
kastiglione wrote:
> In this diff, it seems the debugger_id is always given. Is the `Optional`ality for future uses?
Yeah, my thinking was that modules are rarely tied to a single debugger, but these particular function are only called from the process. I'll make them non-optional. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123698/new/

https://reviews.llvm.org/D123698