[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

[Dave Lee via Phabricator via lldb-commits]

kastiglione accepted this revision.
kastiglione added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/include/lldb/Core/Module.h:820-825
+  void ReportWarningOptimization(
+      llvm::Optional<lldb::user_id_t> debugger_id = llvm::None);
+
+  void ReportWarningUnsupportedLanguage(
+      lldb::LanguageType language,
+      llvm::Optional<lldb::user_id_t> debugger_id = llvm::None);
----------------
In this diff, it seems the debugger_id is always given. Is the `Optional`ality for future uses?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123698/new/

https://reviews.llvm.org/D123698