[Lldb-commits] [PATCH] D122093: [trace][intelpt] Added total memory usage by decoded trace

[Alisamar Husain via Phabricator via lldb-commits]

zrthxn marked 4 inline comments as done.
zrthxn added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:119
+  s.Printf("  Total approximate memory usage: %0.2lf KiB\n",
+           (float)mem_used / 1024);
   return;
----------------
wallace wrote:
> use double instead of float. double has more precision
But since we're showing only two decimal places, which gets rounded up, the precision eventually gets thrown away... doesn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122093/new/

https://reviews.llvm.org/D122093