[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:971
+          "need module to resolve file address for %s", dw_op_type);
+    return {};
+  }
----------------
clayborg wrote:
> Do we prefer "return {}" over "return llvm::None"?
Personally, I do, but there's no rule about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121408/new/

https://reviews.llvm.org/D121408