[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 14 13:46:46 PDT 2022


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125
 
 def getPlatform():
     """Returns the target platform which the tests are running on."""
----------------
labath wrote:
> I'm not sure if this will work for all apple platforms. Can I assume all of them have `configuration.apple_sdk` set?
Only for our "on-device" test suite (i.e. embedded platforms). Seems like the host case is handled below so that should be fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121605/new/

https://reviews.llvm.org/D121605



More information about the lldb-commits mailing list