[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: JDevlieghere, jingham, clayborg.
Herald added a project: All.
labath requested review of this revision.
Herald added a project: LLDB.

The decision which categories are relevant for a particular test run
happen very early in the test setup process. They use the SBPlatform
object to determine which categories should be skipped. The platform
object created for this purpose transcends individual test runs.

This setup is not compatible with the direction discussed in
https://discourse.llvm.org/t/multiple-platforms-with-the-same-name/59594

- when platform objects are tied to a specific (SB)Debugger, they need

to be created alongside it, which currently happens in the test setUp
method.

This patch is the first step in that direction -- it rewrites the
category skipping logic to avoid depending on a global SBPlatform
object. Fortunately, the skipping logic is fairly simple (and I believe
it outght to stay that way) and mainly consists of comparing the
platform name against some hardcoded lists. This patch bases this
comparison on the platform name instead of the os part of the triple (as
reported by the platform).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121605

Files:
  lldb/packages/Python/lldbsuite/test/dotest.py
  lldb/packages/Python/lldbsuite/test/lldbplatformutil.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121605.415106.patch
Type: text/x-patch
Size: 4367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220314/f3243199/attachment.bin>