[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 14 01:55:53 PDT 2022


labath added a comment.

That is roughly what I had in mind, *but* if you look inside `Editline` class, you'll see that it already declares a `std::mutex m_output_mutex` variable. It was introduced for the same reason as this mutex here, although it only controls stdout access during command line editing (and not when the command output is printed).

Ideally we wouldn't have two mutexes controlling stdout access. I think it should be possible to delete the mutex in the Editline class, and replace it with (a reference to?) the mutex you define here, but I haven't tried proving to myself that this will work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121537/new/

https://reviews.llvm.org/D121537



More information about the lldb-commits mailing list