[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 11 17:41:53 PST 2022


JDevlieghere added a comment.

In D121500#3376497 <https://reviews.llvm.org/D121500#3376497>, @jingham wrote:

> LGTM.  It might be worthwhile to audit the uses of Debugger::GetErrorFile & GetOutputFile to see which of them really should also be using the lockable stream instead.  That would be fine as a separate commit, however.

Yup, that's exactly what I started doing. I'm aware of at least one offender (https://reviews.llvm.org/D121502) because I just added that. But I'll see if there are other places that can be migrated to use the Stream instead of the File.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121500/new/

https://reviews.llvm.org/D121500



More information about the lldb-commits mailing list