[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Mar 11 17:08:12 PST 2022


JDevlieghere added inline comments.


================
Comment at: lldb/source/API/SBTarget.cpp:1596-1597
+  if (target_sp) {
+    std::string abi_name(target_sp->GetABIName().str());
+    ConstString const_name(abi_name.c_str());
+    return const_name.GetCString();
----------------
I think `ConstString` has a ctor that takes a StringRef so you should be able to do  `ConstString abi_name(target_sp->GetABIName())` directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121348/new/

https://reviews.llvm.org/D121348



More information about the lldb-commits mailing list