[Lldb-commits] [lldb] 94bda3a - [lldb] Removed scoped timer from ReadMemoryFromFileCache

[Dave Lee via lldb-commits]

Author: Dave Lee
Date: 2022-03-11T12:46:38-08:00
New Revision: 94bda3aaa12192660cd8da3a7b3bf9749b2a2c44

URL: https://github.com/llvm/llvm-project/commit/94bda3aaa12192660cd8da3a7b3bf9749b2a2c44
DIFF: https://github.com/llvm/llvm-project/commit/94bda3aaa12192660cd8da3a7b3bf9749b2a2c44.diff

LOG: [lldb] Removed scoped timer from ReadMemoryFromFileCache

`ReadMemoryFromFileCache` can be called at a high rate, and has fast execution.
Signposts for high rate & brief duration can have a negative impact on tracing;
emitting a high volume signposts can lead to blocking, affecting performance,
and total volume makes human review of the trace harder because of the noise.

Differential Revision: https://reviews.llvm.org/D121226

Added: 
    

Modified: 
    lldb/source/Target/Target.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp
index 6e8cc1df89398..31e6cdbe39b81 100644
--- a/lldb/source/Target/Target.cpp
+++ b/lldb/source/Target/Target.cpp
@@ -1684,7 +1684,6 @@ bool Target::ModuleIsExcludedForUnconstrainedSearches(
 
 size_t Target::ReadMemoryFromFileCache(const Address &addr, void *dst,
                                        size_t dst_len, Status &error) {
-  LLDB_SCOPED_TIMER();
   SectionSP section_sp(addr.GetSection());
   if (section_sp) {
     // If the contents of this section are encrypted, the on-disk file is