[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lldb/source/Expression/DWARFExpression.cpp:962
+///          check_sectionoffset is true we consider LLDB_INVALID_ADDRESS a
+///          success if so_addr.IsSectionOffset() is true.
+static llvm::Optional<lldb::addr_t>
----------------
Thanks! I would have been happy with just the function description ;-)


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:1363
 
-      case Value::ValueType::FileAddress:
+      // case Value::ValueType::FileAddress:
       case Value::ValueType::Invalid:
----------------
Why is this commented out?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121408/new/

https://reviews.llvm.org/D121408