[Lldb-commits] [lldb] c24199e - [lldb] Always listen for progress events in the default event handler

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 10 12:51:33 PST 2022


Author: Jonas Devlieghere
Date: 2022-03-10T12:51:27-08:00
New Revision: c24199e8e885800147aa98ce2b48b5d830bd51ed

URL: https://github.com/llvm/llvm-project/commit/c24199e8e885800147aa98ce2b48b5d830bd51ed
DIFF: https://github.com/llvm/llvm-project/commit/c24199e8e885800147aa98ce2b48b5d830bd51ed.diff

LOG: [lldb] Always listen for progress events in the default event handler

We came to the conclusion that this doesn't matter for VSCode/Xcode
because they don't use the default event loop and that other clients
who might care should use the setting.

Differential revision: https://reviews.llvm.org/D120972

Added: 
    

Modified: 
    lldb/source/Core/Debugger.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp
index 3d3bc75b34eb1..57e7ca4588f3d 100644
--- a/lldb/source/Core/Debugger.cpp
+++ b/lldb/source/Core/Debugger.cpp
@@ -1631,10 +1631,8 @@ lldb::thread_result_t Debugger::DefaultEventHandler() {
           CommandInterpreter::eBroadcastBitAsynchronousOutputData |
           CommandInterpreter::eBroadcastBitAsynchronousErrorData);
 
-  if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) {
-    listener_sp->StartListeningForEvents(&m_broadcaster,
-                                         Debugger::eBroadcastBitProgress);
-  }
+  listener_sp->StartListeningForEvents(&m_broadcaster,
+                                       Debugger::eBroadcastBitProgress);
 
   // Let the thread that spawned us know that we have started up and that we
   // are now listening to all required events so no events get missed


        


More information about the lldb-commits mailing list