[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/Platform/gdb-server/CMakeLists.txt:10
     lldbPluginProcessUtility
+    lldbPluginProcessGDBRemote
   )
----------------
thakis wrote:
> It doesn't seem like lldb cares about this kind of thing, but this adds a dependency cycle: lldbPluginPlatformGDB->lldbPluginProcessGDBRemote->lldbPluginPlatformMacOSX->lldbPluginPlatformPOSIX->lldbPluginPlatformGDB
Actually, this is something I wanted to address before landing this patch (but then forgot).  I think that the dependencies introduced (I would actually say "made explicit") here are reasonable, and the weird one is  `lldbPluginProcessGDBRemote->lldbPluginPlatformMacOSX`). Lemme back this out until I figure out what to do with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120810/new/

https://reviews.llvm.org/D120810