[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 8 14:58:39 PST 2022


clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

In D120972#3368244 <https://reviews.llvm.org/D120972#3368244>, @JDevlieghere wrote:

> In D120972#3368055 <https://reviews.llvm.org/D120972#3368055>, @jingham wrote:
>
>> In D120972#3368008 <https://reviews.llvm.org/D120972#3368008>, @clayborg wrote:
>>
>>> This is fine as a starting point, my only question is if the setting should be "interpreter.show-progress"
>>
>> Whether you see this output is really dependent on how the debugger's I/O is set up, which seems more like a feature of the Debugger than of the CommandInterpreter.  This seems more like the stop display than like whether we prompt on quit or echo commands.
>
> Exactly, there's nothing that ties this to the interpreter, so I think it makes sense to keep it where it is. I also tried to make that more explicit by referencing the debugger's output in the help message.

ok. Thanks for the info


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120972/new/

https://reviews.llvm.org/D120972



More information about the lldb-commits mailing list